Skip to content

Commit

Permalink
Expand support for node@18 (#1884)
Browse files Browse the repository at this point in the history
* Expand support for node@18
  • Loading branch information
trevor-scheer authored and benweatherman committed Jun 24, 2022
1 parent 75e946a commit 3af462c
Show file tree
Hide file tree
Showing 11 changed files with 49 additions and 39 deletions.
27 changes: 12 additions & 15 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ commands:
common_test_steps:
description: "Commands run on each Node.js job"
steps:
- oss/install_specific_npm_version:
version: '7'
- checkout
- oss/npm_clean_install_with_caching
- run:
Expand All @@ -39,7 +37,7 @@ jobs:

NodeJS 12:
docker:
- image: cimg/node:12.22.1
- image: cimg/node:12.22
steps:
- common_test_steps
# We will save the results of this one particular invocation to use in
Expand All @@ -54,19 +52,19 @@ jobs:

NodeJS 14:
docker:
- image: cimg/node:14.16.1
- image: cimg/node:14.19
steps:
- common_test_steps

NodeJS 16:
docker:
- image: cimg/node:16.0.0
- image: cimg/node:16.15
steps:
- common_test_steps
NodeJS 17:

NodeJS 18:
docker:
- image: cimg/node:17.0.0
- image: cimg/node:18.2.0
steps:
- common_test_steps

Expand All @@ -93,10 +91,8 @@ jobs:
GraphQL Types:
description: "Assert generated GraphQL types are up to date"
docker:
- image: cimg/node:14.16.1
- image: cimg/node:16.15
steps:
- oss/install_specific_npm_version:
version: '7'
- checkout
- oss/npm_clean_install_with_caching
- run:
Expand Down Expand Up @@ -137,10 +133,11 @@ workflows:
- NodeJS 16:
name: "JS: Node 16"
<<: *common_non_publish_filters
- NodeJS 18:
name: "JS: Node 18"
<<: *common_non_publish_filters
- GraphQL v15 Support:
name: "Backcompat support: graphql@15"
- NodeJS 17:
name: "JS: Node 17"
<<: *common_non_publish_filters
- GraphQL Types:
name: "GraphQL Types (up to date)"
Expand All @@ -152,7 +149,7 @@ workflows:
- "JS: Node 12"
- "JS: Node 14"
- "JS: Node 16"
- "JS: Node 17"
- "JS: Node 18"
- "Backcompat support: graphql@15"
- "GraphQL Types (up to date)"
- oss/dry_run:
Expand All @@ -162,7 +159,7 @@ workflows:
- "JS: Node 12"
- "JS: Node 14"
- "JS: Node 16"
- "JS: Node 17"
- "JS: Node 18"
- "Backcompat support: graphql@15"
- "GraphQL Types (up to date)"
- oss/confirmation:
Expand Down
4 changes: 1 addition & 3 deletions federation-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the `0.x` range. T

## vNEXT

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.
- _Nothing yet! Stay tuned._
- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)

## v0.36.1

Expand Down
2 changes: 1 addition & 1 deletion federation-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Apollo <packages@apollographql.com>",
"license": "MIT",
"engines": {
"node": ">=12.13.0 <18.0"
"node": ">=12.13.0"
},
"publishConfig": {
"access": "public"
Expand Down
3 changes: 1 addition & 2 deletions gateway-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
This CHANGELOG pertains only to Apollo Federation packages in the `0.x` range. The Federation v2 equivalent for this package can be found [here](https://github.com/apollographql/federation/blob/main/gateway-js/CHANGELOG.md) on the `main` branch of this repo.

## vNEXT
> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually)

- Nothing yet! Stay tuned.
- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)

## v0.51.0

Expand Down
4 changes: 2 additions & 2 deletions gateway-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"apollo"
],
"engines": {
"node": ">=12.13.0 <18.0"
"node": ">=12.13.0"
},
"license": "MIT",
"publishConfig": {
Expand All @@ -28,7 +28,7 @@
"@apollo/core-schema": "^0.2.0",
"@apollo/federation": "file:../federation-js",
"@apollo/query-planner": "file:../query-planner-js",
"@apollo/utils.createhash": "^1.0.0",
"@apollo/utils.createhash": "^1.1.0",
"@apollo/utils.fetcher": "^1.0.0",
"@apollo/utils.logger": "^1.0.0",
"@josephg/resolvable": "^1.0.1",
Expand Down
34 changes: 27 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"codegen:check": "npm run codegen && git diff --exit-code"
},
"engines": {
"node": ">=12.13.0 <18.0",
"node": ">=12.13.0",
"npm": ">=7 <9"
},
"dependencies": {
Expand Down
4 changes: 1 addition & 3 deletions query-planner-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the `0.x` range. T

## vNEXT

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.
- _Nothing yet! Stay tuned._
- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)

## v0.10.2

Expand Down
2 changes: 1 addition & 1 deletion query-planner-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"apollo"
],
"engines": {
"node": ">=12.13.0 <18.0"
"node": ">=12.13.0"
},
"license": "MIT",
"publishConfig": {
Expand Down
4 changes: 1 addition & 3 deletions subgraph-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the `0.x` range. T

## vNEXT

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.
- Nothing yet! Stay tuned.
- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)

## v0.4.2

Expand Down
2 changes: 1 addition & 1 deletion subgraph-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "Apollo <packages@apollographql.com>",
"license": "MIT",
"engines": {
"node": ">=12.13.0 <18.0"
"node": ">=12.13.0"
},
"publishConfig": {
"access": "public"
Expand Down

0 comments on commit 3af462c

Please sign in to comment.