Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for queries, includes, and excludes flags for codegen #733

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

trevor-scheer
Copy link
Member

After the overhaul, support for the queries flag in codegen was altered. This restores previous behavior and add includes and excludes flags.

Note: excludes patterns don't work in watch mode due to a limitation with
Gaze, the file watcher we're using.

Tested:

  • Using flags in combinations: includes, includes + excludes, queries
  • With watch flag

After the overhaul, support for the queries flag in codegen was altered.
Restore previous behavior and add includes and excludes flags.

Note: excludes patterns don't work in watch mode due to a limitation with
Gaze, the filewatcher we're using.
Copy link
Contributor

@martijnwalraven martijnwalraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's revisit watch mode later. We may want to switch to a different file watcher and integrate watching more closely with the language server.

@trevor-scheer trevor-scheer merged commit 6104d84 into master Nov 21, 2018
@trevor-scheer trevor-scheer deleted the trevor/fix-queries-flag branch November 21, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants