Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation for apollo.config.js #712

Closed
wants to merge 1 commit into from

Conversation

milosdanilov
Copy link
Contributor

  • Add a missing documentation for "includes" and "excludes"
  • Add a note to --queries argument in apollo client:codegen command

Problem is referenced in: #696 (comment)

- Add a missing documentation for "includes" and "excludes"
- Add a note to --queries argument in apollo client:codegen command

Problem is referenced in: apollographql#696 (comment)
@apollo-cla
Copy link

@milosdanilov: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@trevor-scheer
Copy link
Member

Hey @milosdanilov, thanks for submitting a PR! The documentation that you're editing is auto-generated when we publish, so this would be overwritten without changes to the actual code.

This is a relevant PR #733 that was just merged, and the related publish commit: 4898efc

This should demonstrate how some of the docs are added (see description on the flags). It also might have resolved the issue you were looking to resolve, but if not then feel free to make update your PR with the changes that should be made 👍

@trevor-scheer
Copy link
Member

@milosdanilov is this resolved? If so can we close this? Thanks!

@milosdanilov
Copy link
Contributor Author

@trevor-scheer yes, you can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants