Remove dependency on graphql-js internal Maybe type #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2020
Closed
abernix
added a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…ollo-server#4230) Co-authored-by: Jesse Rosenberger <git@jro.cc> Apollo-Orig-Commit-AS: apollographql/apollo-server@d799e93
This was referenced Sep 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4223
Per graphql/graphql-js#2621 (comment),
Maybeis an internal type for graphql-js, which is why it isn't re-exported from index.d.ts. They moved it fromtsutilstojsutilsin v15.1.0 which breaks the deep import in apollo-federation.This PR solves the issue by defining
Maybeinternally rather than importing it from graphql-js.