Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4223 Moved Maybe #4224

Closed

Conversation

anisebamford
Copy link

  • Update the import of Maybe to match its location in graphql.

@apollo-cla
Copy link

@bumpusfrancus: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@anisebamford
Copy link
Author

anisebamford commented Jun 9, 2020

Fixes #4223

* Update the import of Maybe to match its location in graphql.
* Update package.json.
@haines
Copy link
Contributor

haines commented Jun 10, 2020

I've raised an alternative solution (#4230) in light of graphql/graphql-js#2621 (comment)

@anisebamford
Copy link
Author

@haines Has a better solution. It looks like graphql is redefining Maybe based on https://flow.org/en/docs/types/maybe/.

@abernix abernix added this to the Release 2.14.4 milestone Jun 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants