[Federation] Normalize SDL in a normalization step before validation #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeDawkins
reviewed
Jun 4, 2019
|
|
||
| type RootMutation { | ||
| keepThisField: String | ||
| removeThisField: Query |
c8da5af to
fdac729
Compare
Currently, we perform transformations to normalize an individual service's SDL during composition. One of the normalizations (@extends directive) should actually be performed before validation happens for simplicity. The result of this realization was to pull out SDL normalization into a separate step which happens before composition.
ab0a99e to
abb5d51
Compare
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…pollographql/apollo-server#2771) Currently, we perform transformations to normalize an individual service's SDL during composition. One of the normalizations (`@extends` directive) should actually be performed before composition happens for simplicity. The result of this realization was to pull out SDL normalization into a separate step which happens before composition. Noteworthy changes: * Filter @extends directives after transforming to `extend type` (they're extraneous) * Perform schema normalizations before composition Apollo-Orig-Commit-AS: apollographql/apollo-server@0a9af35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we perform transformations to normalize an individual
service's SDL during composition. One of the normalizations
(@extends directive) should actually be performed before validation
happens for simplicity.
The result of this realization was to pull out SDL normalization
into a separate step which happens before composition.
For now, normalization is two steps:
type Thing @extends ...toextend type Thing ...RootQuerytoQueryThis PR mostly moves things around (where the normalization functions live and their tests)