Fix validations w.r.t. @extends for type extensions #2770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates pre-composition validations that make decisions based on type definitions and type extensions. These validations should account for the @extends directive, and treat type definitions that use it as type extensions.
387c633 to
6dd5521
Compare
|
Closed in favor of previously mentioned approach: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update validations that act on base types / type extensions …
Updates pre-composition validations that make decisions based on
type definitions and type extensions. These validations should
account for the @extends directive, and treat type definitions
that use it as type extensions.
Alternate approach worth considering:
Transform the incoming schema (
type Thing @extends ...->extend type Thing)The advantage of doing this is that we "normalize" the schema when we receive it and disregard
@extendseverywhere.