-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds a prettier ignore file #9809
Conversation
One thing to note on this before merging ,locally I still saw prettier overwriting the A way to test this PR would be to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me if it does what it says on the tin!
Before I merge, I just wanted to get @benjamn approval on this thanks @StephenBarlow ! |
@alessbell 👋 This is a pretty straight forward PR for using a prettier ignore file in our repo, So I though this may be something you could review. |
@jpvajda yep, this has the intended effect. The only thing I'd note is that we removed Prettier from the repo 2 years ago (#5227), so adding this ignore file only affects those who have a Prettier plugin installed via IDE extension configured to format on save and don't want to have to manually 'save without formatting' (or disable their Prettier plugin). |
yes, that would be the intention with this change. 😄 This actually is my exact use case as well. I notice the Circle CI test is now failing so let me do a rebase on this branch and see if that fixes the test failure. |
Sounds good to me 👍
FWIW I had a test fail when I opened a PR just now and I just had to click the re-run button via the web UI for them to pass |
This PR adds a
.prettierignore
file in order to prevent prettier from over writing some formatting choices we've made for our docs.Relates to
#9777
References
https://prettier.io/docs/en/ignore.html#ignoring-files