Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes expansion panel #9777

Merged
merged 2 commits into from
Jun 9, 2022
Merged

fixes expansion panel #9777

merged 2 commits into from
Jun 9, 2022

Conversation

jpvajda
Copy link
Contributor

@jpvajda jpvajda commented Jun 1, 2022

Steps to reproduce

  1. go to this page: https://www.apollographql.com/docs/react/data/error-handling/
  2. try to expand the expansion panels

This PR fixes a problem where the expansion panels in this docs page wouldn't expand. There seemed to be an old import reference to a deprecated component which might have been impacting the other components on this page. The link chain code seemed to be referencing what is documented here. . So I just added that code in manually.

Also it seems we no longer need an important statement for components, based on this section of docs readme.

The Linkedchain component no longer seems to be available in the docs source code.

@jpvajda jpvajda requested a review from StephenBarlow as a code owner June 1, 2022 19:26
@jpvajda jpvajda self-assigned this Jun 1, 2022
@jpvajda
Copy link
Contributor Author

jpvajda commented Jun 1, 2022

@StephenBarlow I was hoping you could review this fix for me.

Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for catching! One request around list bullets

@jpvajda
Copy link
Contributor Author

jpvajda commented Jun 7, 2022

@benjamn I'm having an issue with a test failing on Circle CI but all tests pass locally. I've even ran the individual failed test independently and that also passes.

jest --config ./config/jest.config.js --testRegex __tests__/batchLink.ts

all tests pass
Screen Shot 2022-06-07 at 11 06 50 AM

batchLink.ts test passes
Screen Shot 2022-06-07 at 11 07 36 AM

Any thoughts on what might be the issue here?

@hwillson hwillson force-pushed the error-handling-expansion-panel-fix branch from b9e9da7 to ad494cb Compare June 9, 2022 10:39
@hwillson
Copy link
Member

hwillson commented Jun 9, 2022

@jpvajda I just rebased against main and the tests passed ... 🤷‍♂️. Gremlins in the system for sure, but we should now be good to go. Thanks!

@jpvajda jpvajda merged commit 9553b1f into main Jun 9, 2022
@jpvajda
Copy link
Contributor Author

jpvajda commented Jun 9, 2022

Thanks for the assist here @hwillson !

@jpvajda jpvajda deleted the error-handling-expansion-panel-fix branch June 9, 2022 15:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants