Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #9793 from release-3.7 branch to main #9807

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Jun 10, 2022

PR #9793 was first released in v3.7.0-beta.3 for testing, and now (in this PR) will be backported to the main branch, to be released in the next v3.6.x patch version, fixing a BatchHttpLink regression introduced in v3.6.0 that silently discarded some pending queries.

Evidence this worked:

PR #9793 was first released in v3.7.0-beta.3 for testing, and now (in
this PR) will be backported to the `main` branch, to be released in the
next v3.6.x patch version, fixing a `BatchHttpLink` regression
introduced in v3.6.0 that silently discarded some pending queries.

Evidence this worked:
- #9773 (comment)
- #9690 (comment)
- #9690 (comment)
- #9690 (comment)
- #9690 (comment)

userEvent.click(screen.getByRole('button', { name: /mutate/i }));

await screen.findByText('item 3');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was heavily inspired by the one provided by @skrivle in #9773.

This screen API is new to me. I'll have to try that elsewhere!

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @benjamn!

@benjamn benjamn merged commit 9774e15 into main Jun 10, 2022
@benjamn benjamn deleted the backport-3.6.x-pr-9793-fixing-BatchHttpLink branch June 10, 2022 17:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants