Fix BatchHttpLink regression that silently discarded some pending queries
#9793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cel" This reverts commit cefd24c, reversing changes made to d98f1de. I plan to publish this version in the next v3.7.0 beta release, then immediately reinstate most of this functionality, with a narrower attempt to solve issue #9773 in a follow-up beta release, to allow folks to compare the behavior of those two versions.
This reverts commit 0e68db1.
Inspired by issue #9773.
Should fix issue #9773.
This was
linked to
issues
Jun 7, 2022
This was referenced Jun 7, 2022
benjamn
added a commit
that referenced
this pull request
Jun 10, 2022
PR #9793 was first released in v3.7.0-beta.3 for testing, and now (in this PR) will be backported to the `main` branch, to be released in the next v3.6.x patch version, fixing a `BatchHttpLink` regression introduced in v3.6.0 that silently discarded some pending queries. Evidence this worked: - #9773 (comment) - #9690 (comment) - #9690 (comment) - #9690 (comment) - #9690 (comment)
benjamn
added a commit
that referenced
this pull request
Jun 10, 2022
benjamn
commented
Jun 10, 2022
|
|
||
| userEvent.click(screen.getByRole('button', { name: /mutate/i })); | ||
|
|
||
| await screen.findByText('item 3'); |
There was a problem hiding this comment.
Glad I was able to help! Testing Library is great, definitely worth checking it out!
benjamn
added a commit
that referenced
this pull request
Jun 10, 2022
|
@benjamn this issue seems to be back with the release of 3.7.0. Some queries are hanging indefinitely in the loading state. Replacing the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix both #9690 and #9773 by first reverting PR #9248 (which seems to be the source of the problems with
BatchHttpLink), then publishing@apollo/client@3.7.0-beta.2for comparison purposes, then un-reverting #9248 and instead tweaking the unsubscription logic to make all the tests pass (with most of PR #9428 still applied), then publishing@apollo/client@3.7.0-beta.3with the final changes, so folks can try/test both versions on therelease-3.7branch before we release these changes in the next v3.6.x release (hence the v3.6.x patch releases milestone).