Sourcemaps for rollup bundles #3042
Conversation
Generated by 🚫 dangerJS |
|
@evans Oh man I'd be thrilled to merge that in there, ASAP. It's been driving me nuts, and I have a PR where I got a red-flagged code-coverage report and I want to increase it, and I can't figure out what lines are wrong. I'm |
There was a problem hiding this comment.
I think I found a bug. It's possible I don't understand the code-flow. I haven't run this code yet, I'm just trying to port it into apollo-link-rest (apollographql/apollo-link-rest#76).
| config.output = Object.assign( | ||
| { | ||
| file: 'lib/bundle.umd.js', | ||
| format: 'umd', | ||
| name, |
There was a problem hiding this comment.
If you look at the structure of this diff, I think there's a bug.
It looks like you're embedding fields that were outside of config.output, into the output object.
There was a problem hiding this comment.
It looks like a newer version of rollup wants these things moved round and renamed:
The following options have been renamed — please update your config: entry -> input, name -> output.name, sourceMap -> output.sourcemap, exports -> output.exports
7925a15 to
bad187b
Compare
The ts-jest package requires the
coverageMapoption to be enabled to get accurate coverage mapping back to the typescript files.The rollup bundles' sourcemaps were pointing to the compiled javascript files, now they point a the ts files.