Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨🐛 Code coverage / Source-map lines are nonsense: tsconfig issue? #76

Closed
fbartho opened this issue Feb 23, 2018 · 2 comments
Closed

🔨🐛 Code coverage / Source-map lines are nonsense: tsconfig issue? #76

fbartho opened this issue Feb 23, 2018 · 2 comments
Labels
bug 🐛 help wanted 🛠

Comments

@fbartho
Copy link
Collaborator

fbartho commented Feb 23, 2018

This has been driving me nuts, but the Sourcemaps generated for this repo appear to be wrong when debugging, and the Codecov.io reports reference nonsense lines being covered. (Comments can't have code coverage!!)

I don't know what's at fault, but I think it might be tsconfig? or something with bundling for NPM?

I'd love any help to figure this out.
@fbartho fbartho mentioned this issue Feb 23, 2018
Merged
@fbartho fbartho mentioned this issue Feb 25, 2018
Merged
@fbartho fbartho reopened this Feb 25, 2018
@fbartho
Copy link
Collaborator Author

fbartho commented Feb 25, 2018

PR #78 didn't actually fix this, but I think the changes were good, so I merged it. Reopening this issue because it's still a frustrating bug.

@fbartho fbartho mentioned this issue Feb 26, 2018
Merged
@fbartho
Copy link
Collaborator Author

fbartho commented Feb 27, 2018

Fixed!

@fbartho fbartho closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 help wanted 🛠
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fbartho