Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more object assign #1648

Merged

Conversation

borisnieuwenhuis
Copy link

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

unfortunately my editor settings are such that it hides directories called data, previous pr [#1643] was not complete

@borisnieuwenhuis
Copy link
Author

borisnieuwenhuis commented May 3, 2017

no clue why it fails

@borisnieuwenhuis
Copy link
Author

$ git clone -b move-types https://github.com/apollographql/react-apollo
Cloning into 'react-apollo'...
fatal: Remote branch move-types not found in upstream origin
Unexpected end of command stream

??

@helfer
Copy link
Contributor

helfer commented May 3, 2017

I think you just needed to rebase 😉

@helfer
Copy link
Contributor

helfer commented May 3, 2017

Thanks! ❤️

@helfer helfer merged commit 2bd0d17 into apollographql:master May 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants