Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace object.assign by util.assign to make it work in IE #1643

Merged
merged 1 commit into from
May 2, 2017

Conversation

borisnieuwenhuis
Copy link

@borisnieuwenhuis borisnieuwenhuis commented May 2, 2017

Fixes #1642

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@apollo-cla
Copy link

@borisnieuwenhuis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@borisnieuwenhuis borisnieuwenhuis changed the title replace object.assign by utl.assign to make it work in IE replace object.assign by util.assign to make it work in IE May 2, 2017
@helfer
Copy link
Contributor

helfer commented May 2, 2017

Thanks @borisnieuwenhuis, could you make sure the tests pass and also add a changelog entry? 🙂

@borisnieuwenhuis
Copy link
Author

@helfer looks like all test are passing now.
it is my first typescript so I hope it is sort of ok :-)

check if source is set

update CHANGELOG.md with fix description
@helfer
Copy link
Contributor

helfer commented May 2, 2017

Looks great, thanks a lot @borisnieuwenhuis !

@helfer helfer merged commit 68441b5 into apollographql:master May 2, 2017
@borisnieuwenhuis borisnieuwenhuis mentioned this pull request May 3, 2017
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants