Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add disconnect event listener for wallets #526

Merged
merged 1 commit into from
Oct 30, 2024
Merged

core: add disconnect event listener for wallets #526

merged 1 commit into from
Oct 30, 2024

Conversation

jaipaljadeja
Copy link
Member

@jaipaljadeja jaipaljadeja commented Oct 30, 2024 •
edited
Loading

when user disconnects dApp from the wallet ui itself, it will emit disconnect event using which we update starknet state.
resolves #520

@jaipaljadeja jaipaljadeja requested a review from fracek as a code owner October 30, 2024 13:51
@jaipaljadeja jaipaljadeja force-pushed the fix/disconnect-wallet-event branch from 5b4d37e to f9b9904 Compare October 30, 2024 13:53
fracek
fracek approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@fracek fracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works!

@jaipaljadeja jaipaljadeja force-pushed the fix/disconnect-wallet-event branch from f9b9904 to 8e20d64 Compare October 30, 2024 13:56
@fracek fracek merged commit 3d5aec9 into apibara:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fracek fracek fracek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: disconnecting from the wallet UI doesn't trigger anything
2 participants
@jaipaljadeja @fracek