Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: disconnecting from the wallet UI doesn't trigger anything #520

Closed
enitrat opened this issue Oct 23, 2024 · 4 comments · Fixed by #526
Closed

bug: disconnecting from the wallet UI doesn't trigger anything #520

enitrat opened this issue Oct 23, 2024 · 4 comments · Fixed by #526
Assignees
@jaipaljadeja
Labels
bug

Comments

@enitrat
Copy link
Contributor

enitrat commented Oct 23, 2024

repro:

Go to any starknet dapp (like Ekubo), disconnect from your Argent / Braavos wallet: nothing changes in the Ekubo UI, the wallet stays connected but attempting to click swap will just do nothing.
@od-hunter
Copy link

Hi @enitrat , please is this open for contribution? If yes, I’d love to be assigned this.

@enitrat
Copy link
Contributor Author

enitrat commented Oct 23, 2024

@od-hunter this is a bug report

@od-hunter
Copy link

@od-hunter this is a bug report

Ok ser

@fracek fracek added the bug label Oct 29, 2024
@fracek
Copy link
Contributor

fracek commented Oct 29, 2024

Thanks. Will look into it.

@jaipaljadeja jaipaljadeja mentioned this issue Oct 30, 2024
Merged
fracek added a commit that referenced this issue Oct 30, 2024
@fracek
core: add disconnect event listener for wallets (#526)
3d5aec9 
when user disconnects dApp from the wallet ui itself, it will emit
`disconnect` event using which we update starknet state.

resolves #520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaipaljadeja jaipaljadeja

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: add disconnect event listener for wallets jaipaljadeja/starknet-react
5 participants
@fracek @enitrat @jaipaljadeja @od-hunter and others