TP convert ag-grid tables to component #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
reviewed
Jul 20, 2021
traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/agGrid/grid.tpl.html
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/cdnNotifications/TableCDNNotificationsController.js
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Jul 20, 2021
...ortal/app/src/common/modules/table/deliveryServiceJobs/TableDeliveryServiceJobsController.js
Outdated
Show resolved
Hide resolved
...app/src/common/modules/table/deliveryServiceServers/TableDeliveryServiceServersController.js
Outdated
Show resolved
Hide resolved
...app/src/common/modules/table/deliveryServiceServers/TableDeliveryServiceServersController.js
Show resolved
Hide resolved
...app/src/common/modules/table/deliveryServiceServers/TableDeliveryServiceServersController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/changeLogs/TableChangeLogsController.js
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/jobs/table.jobs.tpl.html
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/notifications/TableNotificationsController.js
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/servers/TableServersController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/servers/TableServersController.js
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Jul 21, 2021
...ortal/app/src/common/modules/table/deliveryServiceJobs/TableDeliveryServiceJobsController.js
Outdated
Show resolved
Hide resolved
ocket8888
requested changes
Jul 22, 2021
There was a problem hiding this comment.
Breadcrumb links appear broken.
- Go to Topologies -> Cache Groups
- Click on a Cache Group
- Click on More -> View Servers
- Click on "Cache Groups" in the breadcrumbs
- It tries to take you to
https://localhost/$ctrl.bcGetHref(bc)which can't load, the page shows a single
The entire page content is just
<!DOCTYPE html>
<html lang="en"><head>
<meta charset="utf-8">
<title>Error</title>
</head>
<body>
<pre>Cannot GET /$ctrl.bcGetHref(bc)</pre>
</body>
</html>|
All bread crumbs that had a custom href were broken, fixed now. |
ocket8888
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
It converts several ag-grid tables to the
common-grid-componentWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure the new pages still work, subtle functionality might be different since different versions of the ag-grid code exist.
The following pages have been changed:
The following criteria are ALL met by this PR
Additional Information
The only remaining unconverted tables are deliveryservice and it's derivatives.