Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP: click on change log entry to view in its entirety #6021

Closed
rawlinp opened this issue Jul 13, 2021 · 4 comments · Fixed by #7087
Closed

TP: click on change log entry to view in its entirety #6021

rawlinp opened this issue Jul 13, 2021 · 4 comments · Fixed by #7087
Labels
improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1 Traffic Portal v2 Related to the experimental Traffic Portal version 2

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Jul 13, 2021

I'm submitting a ...

  • enhancement request

Traffic Control components affected ...

  • Traffic Portal

Current behavior:

When viewing the change log table page, e.g. https://tp.example.org/#!/change-logs, long messages are difficult to read, and you cannot click on the entry to open it up to view it in its entirety.

New behavior:

I'd like to be able to click on a change log entry in the table in order to "open it up" (e.g. modal or a new page) to be able to easily read the log message in its entirety.

Minimal reproduction of the problem with instructions:

Go to change log table page, e.g. https://tp.example.org/#!/change-logs, and try clicking on an entry.

Anything else:

Personally, I don't really care if it opens a modal or a new page, I just want to be able to easily read long change log messages.

@rawlinp rawlinp added new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1 labels Jul 13, 2021
@mitchell852
Copy link
Member

mitchell852 commented Jul 19, 2021

this is true of any cell whos contents are too long in the ag-grid column - impossible to read the entire contents. gets truncated with an ... and looks like you can only read via the onhover tooltip. maybe something that @shamrickus can add to his ag-grid component (#6031) or the next iteration of it?

@ocket8888
Copy link
Contributor

FWIW this is trivial with modern Angular Material. Doesn't help current TP, though.

@mitchell852
Copy link
Member

FWIW this is trivial with modern Angular Material. Doesn't help current TP, though.

I added this to the TPv2 project so it doesn't get overlooked.

@mitchell852 mitchell852 added the low difficulty the estimated level of effort to resolve this issue is low label Nov 16, 2021
@mitchell852
Copy link
Member

TPv2 is a ways out. I'm assuming this is low effort so probably worth doing.

@rawlinp rawlinp added the low impact affects only a small portion of a CDN, and cannot itself break one label Dec 7, 2021
@zrhoffman zrhoffman added the Traffic Portal v2 Related to the experimental Traffic Portal version 2 label Jun 9, 2022
@zrhoffman zrhoffman added bug something isn't working as intended and removed new feature A new feature, capability or behavior labels Sep 15, 2022
@zrhoffman zrhoffman added improvement The functionality exists but it could be improved in some way. and removed bug something isn't working as intended labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1 Traffic Portal v2 Related to the experimental Traffic Portal version 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants