Build development RPMs from any OS without needing Docker #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b206e3 to
7f6dc8b
Compare
|
Rebased to fix merge conflicts. |
|
I tested out these changes locally and they work great for me. 👍 |
srijeet0406
approved these changes
Jun 23, 2020
|
Now that #4671 is merged, rebased to support |
- Almquist shellcheck
- Error trap
- Strict shell options
- Return 1 from functions on error instead of exit 1 since we have an
error trap and the errexit option set
- Single brackets for Bourne shell, not double - Use -n instead of ! -z - Use braces for variables inside strings
treat 0 as a successful exit code instead of 1
support an arbitrary number of files
editing RPM definitions
… already run - Do not copy dist directory - Gitignore grove and grovetccfg binaries
- Specify that we want to build for Linux, regardless of host OS
- Use awk to print the first field of wc, since BSD wc starts with a tab
- Support stat -c on BSD systems
- npm, bower, and grunt are already in the path, do not prefix with /usr/bin/
- Specify recursive copy with -R, not -r
- Use ${file.separator} in Traffic Router POMs
- If the build environment is Cygwin, use a Windows GOPATH
stop the build script - Specify environment requirements by component
The Traffic Portal Developer Environment" section
- Move Compass instructions to "Software Requirements" section - Add reference labels
- Change directories to the repo before running if we are not already
there
- Clean build the tarball to exclude gitignored files
- If no projects are provided to clean_build.sh, build them all
- Fix label references - Fix some typos - Link to the Windows footnote from the Chocolatey package row
- Use the sphinx module to build the docs, not the sphinx-build executable - check for python3, not python
|
Rebased onto master |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
sh) instead of Bash for POSIX compatibilityrealpathinstead ofreadlinkwhere possible02:54.0100:53.4400:44.9400:43.6900:50.6501:11.0101:49.9001:44.5600:55.0711:47.2702:11.9400:15.1700:13.5300:06.1000:15.3900:24.1801:01.3400:49.3400:16.3105:33.3001:53.6100:03.3800:03.9700:04.3600:04.9300:10.4000:45.2300:33.9800:07.9803:47.8401:14.6900:02.6800:03.1800:02.9100:03.3700:07.6500:27.9900:18.3200:06.1202:26.9Some comments about the time comparisons table:
./pkg -v [component], Natively refers tobuild/clean_build [component]/tmp/go/src/github.com/apache/trafficcontrol, so thersynccommand inclean_build.shto copy the repo there only affects files that have changed since the last native build../pkgcommand bootstrapsdocker-compose, which takes ~1.6 seconds./tmp/go/src/github.com/apache/trafficcontrolis not a volume, thersynccommand inclean_build.shalways copies the entire repo.rsynctakes on average ~3.2 seconds.Binary size: Static linking vs dynamic linking
Since this PR makes the Go binaries statically linked, whereas before they were dynamically linked, I expected the binaries to be a little larger, but it ends up saving a very small amount of space instead.
726193581118918473100779983722393001112718404100199917385862695866Some comments about the static vs. dynamic linking table:
go build -ldflags '-s -w'and were then stripped of symbols (strip [binary name])go build -ldflags '-s -w' -tags 'osusergo netgo'and were then stripped of symbols (strip [binary name])Besides being a tiny bit smaller, the static binaries will load trivially faster at runtime. However, our statically-linked Go binaries on average take about 1.2 seconds longer to build each.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify that the target OS of the RPMs is Linux
Expected output:
Verify that the RPM compression format is XZ
Expected output:
Verify that all of the packaged Go binaries are statically linked (have no dynamic section). Example for
traffic_ops_golang:docker run --rm -v$(pwd):/mnt centos:7 readelf -d /mnt/traffic_ops_golangExpected output is
In the CDN-in-a-Box directory, run
maketo build the RPMs and verify that CiaB worksdocs/source/development/building.rstunder Build the RPMs Natively, follow the Install the Dependencies instructions for your OSmake nativeto build the RPMs and verify that CiaB works./pkg -v(Docker), verify the RPMs and gzipped TARs that CDN-in-a-Box does not use:build/clean_build.sh(native), verify the RPMs and gzipped TARs that CDN-in-a-Box does not useIf this is a bug fix, what versions of Traffic Control are affected?
For the environment check bugfix:
For #3527:
Otherwise, not a bug fix.
The following criteria are ALL met by this PR