-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ciab atstccfg #4671
Ciab atstccfg #4671
Conversation
60aa41c
to
dc1860a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
There is a merge conflict in |
…nfig fetch to atstccfg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTTP and HTTPS delivery services return successful response codes, CDN-in-a-Box readiness container exits successfully.
What does this PR (Pull Request) do?
This PR depends on #2776 .
Adds
atstccfg
to CDN-in-a-Box, allowing for a better representation of a true ATC system, and eliminating the dependency on my personal PyPI hosting of an old version of the TO Python client.Also fixes the
atstccfg
docs, since the current behavior does not match what is documented.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
The old
test
directory for ORT.py had a single test in it for setting API versions on configuration file objects returned by the old 1.x "meta config" route. Since that's now handled by ATSTCCFG, it's been removed. Instead, there's an executabledoctest-runner.py
file at the top of the ORT.py package that runs the doctests which already existed to some degree. In fact, they helped me find some bugs when I was building this. So just run that file to check for errors in the examples in docstrings.But to be really sure, you'll need to start up CDN-in-a-Box and make sure that the
BADASS
run doesn't fail (which means ORT.py performed every operation it needs to perform and did it successfully). If it does fail, you'll see "Failed" echoed in the edge/mid cache servers' logs. The containers don't crash though, so that the problem can be debugged - so be careful not to assume that. If everything goes well, the "clocks" in TP should be cleared for edge and mid, and both should be marked available by TM.If this is a bug fix, what versions of Traffic Control are affected?
This technically includes a docs bug fix, which is present in:
The following criteria are ALL met by this PR