Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ciab atstccfg #4671

Merged
merged 49 commits into from
Jun 24, 2020
Merged

Ciab atstccfg #4671

merged 49 commits into from
Jun 24, 2020

Conversation

ocket8888
Copy link
Contributor

@ocket8888 ocket8888 commented Apr 29, 2020

What does this PR (Pull Request) do?

  • This PR is not related to any Issue (I think)

This PR depends on #2776 .

Adds atstccfg to CDN-in-a-Box, allowing for a better representation of a true ATC system, and eliminating the dependency on my personal PyPI hosting of an old version of the TO Python client.

Also fixes the atstccfg docs, since the current behavior does not match what is documented.

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Documentation
  • Traffic Ops ORT (Python version and one or two minor changes to ATSTCCFG)

What is the best way to verify this PR?

The old test directory for ORT.py had a single test in it for setting API versions on configuration file objects returned by the old 1.x "meta config" route. Since that's now handled by ATSTCCFG, it's been removed. Instead, there's an executable doctest-runner.py file at the top of the ORT.py package that runs the doctests which already existed to some degree. In fact, they helped me find some bugs when I was building this. So just run that file to check for errors in the examples in docstrings.

But to be really sure, you'll need to start up CDN-in-a-Box and make sure that the BADASS run doesn't fail (which means ORT.py performed every operation it needs to perform and did it successfully). If it does fail, you'll see "Failed" echoed in the edge/mid cache servers' logs. The containers don't crash though, so that the problem can be debugged - so be careful not to assume that. If everything goes well, the "clocks" in TP should be cleared for edge and mid, and both should be marked available by TM.

If this is a bug fix, what versions of Traffic Control are affected?

This technically includes a docs bug fix, which is present in:

  • 4.0
  • 4.1 (RC0)
  • master

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added new feature A new feature, capability or behavior Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script documentation related to documentation medium impact impacts a significant portion of a CDN, or has the potential to do so cdn-in-a-box related to the Docker-based CDN-in-a-Box system labels Apr 29, 2020
@ocket8888 ocket8888 marked this pull request as ready for review April 29, 2020 21:24
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In

infrastructure/cdn-in-a-box/Makefile Outdated Show resolved Hide resolved
infrastructure/cdn-in-a-box/Makefile Outdated Show resolved Hide resolved
infrastructure/cdn-in-a-box/cache/Dockerfile Outdated Show resolved Hide resolved
infrastructure/cdn-in-a-box/ort/traffic_ops_ort/to_api.py Outdated Show resolved Hide resolved
infrastructure/cdn-in-a-box/ort/traffic_ops_ort/to_api.py Outdated Show resolved Hide resolved
infrastructure/cdn-in-a-box/ort/traffic_ops_ort/utils.py Outdated Show resolved Hide resolved
traffic_ops/ort/atstccfg/config/config.go Outdated Show resolved Hide resolved
@ocket8888 ocket8888 marked this pull request as draft May 5, 2020 18:45
@ocket8888 ocket8888 mentioned this pull request May 20, 2020
7 tasks
@zrhoffman
Copy link
Member

There is a merge conflict in traffic_ops_ort/atstccfg/toreqnew/toreqnew.go from #2776 being merged

@ocket8888 ocket8888 marked this pull request as ready for review June 16, 2020 20:35
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP and HTTPS delivery services return successful response codes, CDN-in-a-Box readiness container exits successfully.

@mattjackson220 mattjackson220 merged commit 6c8a801 into apache:master Jun 24, 2020
@ocket8888 ocket8888 deleted the ciab-atstccfg branch June 24, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cdn-in-a-box related to the Docker-based CDN-in-a-Box system documentation related to documentation medium impact impacts a significant portion of a CDN, or has the potential to do so new feature A new feature, capability or behavior Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants