[SIP-5] Repair and refactor CountryMap #5721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5721 +/- ##
==========================================
- Coverage 63.38% 63.37% -0.02%
==========================================
Files 361 361
Lines 22995 22999 +4
Branches 2559 2566 +7
==========================================
Hits 14575 14575
- Misses 8405 8409 +4
Partials 15 15
Continue to review full report at Codecov.
|
williaster
approved these changes
Aug 29, 2018
| k = 1; | ||
| centered = null; | ||
| } | ||
|
|
||
| g.transition() | ||
| .duration(750) | ||
| .attr('transform', 'translate(' + slice.width() / 2 + ',' + slice.height() / 2 + ')scale(' + k + ')translate(' + -x + ',' + -y + ')'); | ||
| .attr('transform', 'translate(' + width / 2 + ',' + height / 2 + ')scale(' + k + ')translate(' + -x + ',' + -y + ')'); |
There was a problem hiding this comment.
could use template literals here to be consistent with transform below
| const vscale = scale * height / (bounds[1][1] - bounds[0][1]); | ||
| const newScale = (hscale < vscale) ? hscale : vscale; | ||
|
|
||
| // Compute bounds and offset using the updated scale. |
Codecov Report
@@ Coverage Diff @@
## master #5721 +/- ##
==========================================
- Coverage 63.78% 63.77% -0.02%
==========================================
Files 364 364
Lines 23073 23078 +5
Branches 2568 2575 +7
==========================================
Hits 14717 14717
- Misses 8341 8346 +5
Partials 15 15
Continue to review full report at Codecov.
|
|
Used template literal and a few minor tweaks. |
|
🚢 |
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 5, 2018
* Extract slice and formData * update css indent * remove no-effect call * improve text label * adjust text size * fix bound calculation * use string literal * make path constant (cherry picked from commit f72cdc3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Extract slice and formData * update css indent * remove no-effect call * improve text label * adjust text size * fix bound calculation * use string literal * make path constant
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Extract slice and formData * update css indent * remove no-effect call * improve text label * adjust text size * fix bound calculation * use string literal * make path constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sliceandformDataBefore
After
Before
After
@williaster @conglei