This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry-picks: Updates 8 charts #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract slice and formData * Define data shape * update style * organize imports * fix heatmap axis labels * add new line * adjust indent (cherry picked from commit fcf2c75)
* extract slice and formdata from sankey * use arrow function * reorganize imports (cherry picked from commit 506cfd1)
* extract slice and formData * update proptypes of data (cherry picked from commit 00cc6e9)
* refactor rose * update proptypes (cherry picked from commit 86f99b0)
* Extract slice and formData * reorder functions * fix tooltip * remove commented code * remove commented code and rename variables * remove verboseMap * rename kx, ky to zoomX, zoomY (cherry picked from commit 00f2771)
* Extract slice and formData * update css indent * remove no-effect call * improve text label * adjust text size * fix bound calculation * use string literal * make path constant (cherry picked from commit f72cdc3)
* remove stroke * update style and annotate data type * update prop type * bring back utc code * add comments (cherry picked from commit 2811498)
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
* Break MapBox into smaller pieces * Replace React.createElement with regular jsx * detach setControlValue * enable render trigger * Pass explicit props rather than pass all that exists in payload.data. Also use formData when possible. * Rename sliceWidth, sliceHeight to width, height. Use deconstructor. Extract function. * use arrow function * fix linting and remove css (cherry picked from commit bebbdb8)
Codecov Report
@@ Coverage Diff @@
## airbnb-master #104 +/- ##
=================================================
- Coverage 63.17% 62.96% -0.21%
=================================================
Files 352 353 +1
Lines 22059 22132 +73
Branches 2471 2477 +6
=================================================
Hits 13935 13935
- Misses 8112 8185 +73
Partials 12 12
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Sep 5, 2018
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
* refactor: use composition package * refactor: remove WithLegend and ChartFrame
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following commit(s):
@john-bodley @conglei @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster
I have verified on devbox with real data and they are working fine.