-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Refresh Native Filters when Dashboard refreshes #15890
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15890 +/- ##
==========================================
- Coverage 77.08% 77.06% -0.03%
==========================================
Files 984 984
Lines 51788 51812 +24
Branches 7037 7042 +5
==========================================
+ Hits 39923 39930 +7
- Misses 11640 11657 +17
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, product sign-off! thanks for the fix!!
…he#15890) * Implement onRefresh action * Update tests * Clean up * Fix type * Add effect dependency
…he#15890) * Implement onRefresh action * Update tests * Clean up * Fix type * Add effect dependency
…he#15890) * Implement onRefresh action * Update tests * Clean up * Fix type * Add effect dependency
…he#15890) * Implement onRefresh action * Update tests * Clean up * Fix type * Add effect dependency
SUMMARY
This PR implements a
onRefresh
action to let the native filters reload when the dashboard reloads.Fixes #15808
BEFORE
126416469-24a7a2ad-3f6b-4da9-9dfd-68d724a1e1eb.mp4
AFTER
untitled.dashb.3.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION