Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Side menu of the dashboard component will scroll out of dashboard #15888

Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix: Side menu of the dashboard component will scroll out of dashboard #15888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,11 @@ const StyledDiv = styled.div`
flex: 1;
`;

// @z-index-above-dashboard-charts + 1 = 11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably start a z-index registry somewhere. The comment is appreciated in the meantime.

const FiltersPanel = styled.div`
grid-column: 1;
grid-row: 1 / span 2;
z-index: 2;
z-index: 11;
`;

const StickyPanel = styled.div<{ width: number }>`
Expand All @@ -82,12 +83,13 @@ const StickyPanel = styled.div<{ width: number }>`
flex: 0 0 ${({ width }) => width}px;
`;

// @z-index-above-dashboard-charts + 1 = 11
const StyledHeader = styled.div`
grid-column: 2;
grid-row: 1;
position: sticky;
top: 0px;
z-index: 2;
z-index: 11;
`;

const StyledContent = styled.div<{
Expand Down