Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Side menu of the dashboard component will scroll out of dashboard #15888

Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix: Side menu of the dashboard component will scroll out of dashboard #15888

merged 1 commit into from
Jul 26, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #15862

@junlincc @jinghua-qa

AFTER SCREENSHOTS OR ANIMATED GIF

screen-recording-2021-07-25-at-105703-am_GVOlMnDd.mp4

TESTING INSTRUCTIONS

See the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #15888 (d55a926) into master (7330aef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15888   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files         984      984           
  Lines       51787    51787           
  Branches     7036     7036           
=======================================
  Hits        39920    39920           
  Misses      11642    11642           
  Partials      225      225
Flag Coverage Δ
javascript 71.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx 90.38% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7330aef...d55a926. Read the comment docs.

rusackas
rusackas reviewed Jul 26, 2021
View reviewed changes
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
@@ -69,10 +69,11 @@ const StyledDiv = styled.div`
flex: 1;
`;

// @z-index-above-dashboard-charts + 1 = 11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably start a z-index registry somewhere. The comment is appreciated in the meantime.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.221.12.115:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit f6115a7 into apache:master Jul 26, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@michael-s-molina
fix: Side menu of the dashboard component will scroll out of dashboard (
ddd1c53 
apache#15888)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@michael-s-molina
fix: Side menu of the dashboard component will scroll out of dashboard (
41915ed 
apache#15888)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@michael-s-molina
fix: Side menu of the dashboard component will scroll out of dashboard (
8867f14 
apache#15888)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
fix: Side menu of the dashboard component will scroll out of dashboard (
368683b 
apache#15888)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cosmetic][dashboard edit] side menu of the dashboard component will scroll out of dashboard
3 participants
@michael-s-molina @rusackas @mistercrunch