fix(explore): Certificate icon not displaying for certified metrics

[kgabryje]

SUMMARY

Certificate icon was not displayed for certified saved metrics in metrics panel and in select options in metrics popover. This PR fixes it and adds some basic tests for OptionControls using react-testing-library.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see #13078
After:

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue: fixes Certification Icons not shown in metric popover select #13078
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

CC: @junlincc @villebro @nikolagigic @etr2460

[codecov-io]

Codecov Report

Merging #13133 (3c436b8) into master (2ce7982) will increase coverage by 8.76%.
The diff coverage is 33.86%.

@@            Coverage Diff             @@
##           master   #13133      +/-   ##
==========================================
+ Coverage   53.06%   61.82%   +8.76%     
==========================================
  Files         489      553      +64     
  Lines       17314    20252    +2938     
  Branches     4482     5300     +818     
==========================================
+ Hits         9187    12521    +3334     
+ Misses       8127     7517     -610     
- Partials        0      214     +214     

Flag	Coverage Δ
cypress	?
javascript	61.82% <33.86%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx	64.28% <ø> (+11.50%)	⬆️
superset-frontend/src/chart/ChartContainer.jsx	100.00% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx	39.18% <0.00%> (-37.53%)	⬇️
...perset-frontend/src/common/components/Dropdown.tsx	54.76% <ø> (+4.76%)	⬆️
...ontend/src/components/ListViewCard/ImageLoader.tsx	86.36% <0.00%> (+11.36%)	⬆️
...set-frontend/src/components/URLShortLinkButton.jsx	100.00% <ø> (ø)
...src/dashboard/components/HeaderActionsDropdown.jsx	54.79% <ø> (-12.78%)	⬇️
...end/src/dashboard/components/StickyVerticalBar.tsx	50.00% <ø> (-50.00%)	⬇️
...ponents/nativeFilters/FilterBar/CascadePopover.tsx	20.28% <0.00%> (-76.38%)	⬇️
...d/components/nativeFilters/FilterBar/FilterBar.tsx	70.93% <0.00%> (-24.46%)	⬇️
... and 521 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312cbf7...3c436b8. Read the comment docs.

[junlincc]

lgtm! approving as product sign-off! Thanks for the quick fix @kgabryje 🙏

Screen.Recording.2021-02-15.at.7.20.43.AM.mov

@etr2460 ready for you code review :)

[villebro]

LGTM. Still have some getting used to with RTL (I still kind of prefer the enzyme way of checking for child components).

[etr2460]

a couple nits, otherwise lgtm. And thanks so much for adding tests!