Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certification Icons not shown in metric popover select #13078

Closed
etr2460 opened this issue Feb 11, 2021 · 2 comments
Closed

Certification Icons not shown in metric popover select #13078

etr2460 opened this issue Feb 11, 2021 · 2 comments
Labels
#bug:regression Bugs that are identified as regessions explore:metrics Related to metrics of Explore explore Namespace | Anything related to Explore

Comments

@etr2460
Copy link
Member

etr2460 commented Feb 11, 2021

Screenshot

image-2021-02-02-12-38-58-762

Description

For the same search query, we show certification icons for the metrics in the dataset sidebar, but not in the metric popover select. I believe this is a regression from previous behavior where we showed the certification icons in both places: see original implementation here: apache-superset/superset-ui#748
@etr2460 etr2460 added explore Namespace | Anything related to Explore #bug:regression Bugs that are identified as regessions explore:metrics Related to metrics of Explore labels Feb 11, 2021
@junlincc
Copy link
Member

junlincc commented Feb 11, 2021 •
edited
Loading

thanks for reporting! I believe we lost the certification icon for a while already.
wasn't familiar with certification feature before so I missed it. we will bring it back soon!

cc: @kgabryje 🙏

@kgabryje kgabryje mentioned this issue Feb 15, 2021
Merged
6 tasks
@zuzana-vej
Copy link
Contributor

resolved by the above linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug:regression Bugs that are identified as regessions explore:metrics Related to metrics of Explore explore Namespace | Anything related to Explore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@etr2460 @zuzana-vej @junlincc