Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51219][SQL][TESTS][FOLLOWUP] ShowTablesExec remove ArrayImplicits #50008

Closed
wants to merge 1 commit into from
Closed

[SPARK-51219][SQL][TESTS][FOLLOWUP] ShowTablesExec remove ArrayImplicits #50008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import org.apache.spark.sql.catalyst.util.StringUtils
import org.apache.spark.sql.connector.catalog.{CatalogV2Util, Identifier, TableCatalog}
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.NamespaceHelper
import org.apache.spark.sql.execution.LeafExecNode
import org.apache.spark.util.ArrayImplicits._

/**
* Physical plan node for showing tables.
Expand All @@ -50,8 +49,7 @@ case class ShowTablesExec(

private def isTempView(ident: Identifier, catalog: TableCatalog): Boolean = {
if (CatalogV2Util.isSessionCatalog(catalog)) {
session.sessionState.catalog
.isTempView((ident.namespace() :+ ident.name()).toImmutableArraySeq)
session.sessionState.catalog.isTempView(ident.namespace() :+ ident.name())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this doesn't compile with scala 2.13 and I added .toSeq when forward porting this commit to 4.0 and master.

} else false
}
}
Loading