[SPARK-51219][SQL][TESTS][FOLLOWUP] ShowTablesExec remove ArrayImplicits
#50008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Feb 20, 2025
cloud-fan
pushed a commit
that referenced
this pull request
Feb 20, 2025
…icits` ### What changes were proposed in this pull request? Related to #49144. scala 2.12 is failing with `ArrayImplicits`, which is in use for `ShowTablesExec.isTempView` method. This PR removes `org.apache.spark.util.ArrayImplicits._` from `ShowTablesExec` and uses default Seq instead. ### Why are the changes needed? To fix failing scala 2.12 compilation isssu. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing init tests and actions run. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50008 from ostronaut/features/ShowTablesExec-remove-ArrayImplicits. Authored-by: Dima <dimanowq@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
pushed a commit
that referenced
this pull request
Feb 20, 2025
…icits` Related to #49144. scala 2.12 is failing with `ArrayImplicits`, which is in use for `ShowTablesExec.isTempView` method. This PR removes `org.apache.spark.util.ArrayImplicits._` from `ShowTablesExec` and uses default Seq instead. To fix failing scala 2.12 compilation isssu. No Existing init tests and actions run. No. Closes #50008 from ostronaut/features/ShowTablesExec-remove-ArrayImplicits. Authored-by: Dima <dimanowq@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 4d15f64) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
thanks, merging to 3.5/4.0/master |
cloud-fan
reviewed
Feb 20, 2025
| @@ -50,8 +49,7 @@ case class ShowTablesExec( | |||
|
|
|||
| private def isTempView(ident: Identifier, catalog: TableCatalog): Boolean = { | |||
| if (CatalogV2Util.isSessionCatalog(catalog)) { | |||
| session.sessionState.catalog | |||
| .isTempView((ident.namespace() :+ ident.name()).toImmutableArraySeq) | |||
| session.sessionState.catalog.isTempView(ident.namespace() :+ ident.name()) | |||
There was a problem hiding this comment.
note: this doesn't compile with scala 2.13 and I added .toSeq when forward porting this commit to 4.0 and master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Related to #49144. scala 2.12 is failing with
ArrayImplicits, which is in use forShowTablesExec.isTempViewmethod. This PR removesorg.apache.spark.util.ArrayImplicits._fromShowTablesExecand uses default Seq instead.Why are the changes needed?
To fix failing scala 2.12 compilation isssu.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing init tests and actions run.
Was this patch authored or co-authored using generative AI tooling?
No.