[SPARK-49773][SQL] Uncaught Java exception from make_timestamp() with bad timezone
#48260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Sep 26, 2024
cloud-fan
reviewed
Sep 26, 2024
srielau
reviewed
Sep 30, 2024
srielau
reviewed
Sep 30, 2024
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala
Outdated
Show resolved
Hide resolved
srielau
suggested changes
Sep 30, 2024
Co-authored-by: Serge Rielau <srielau@users.noreply.github.com>
srielau
reviewed
Sep 30, 2024
Co-authored-by: Serge Rielau <srielau@users.noreply.github.com>
|
Thanks for the fix! |
MaxGekk
requested changes
Oct 3, 2024
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala
Show resolved
Hide resolved
MaxGekk
requested changes
Oct 4, 2024
|
Added test. Thanks! |
make_timestamp() with bad timezone
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…th bad timezone ### What changes were proposed in this pull request? This PR proposes to fix the uncaught Java exception from `make_timestamp()` with bad timezone ### Why are the changes needed? To improve the error message ### Does this PR introduce _any_ user-facing change? No API changes, but the user-facing error message is changed: **Before** ``` spark-sql (default)> select make_timestamp(1, 2, 28, 23, 1, 1, -100); Invalid ID for ZoneOffset, invalid format: -100 ``` **After** ``` spark-sql (default)> select make_timestamp(1, 2, 28, 23, 1, 1, -100); [INVALID_TIMEZONE] The timezone: -100 is invalid. The timezone must be either a region-based zone ID or a zone offset. Region IDs must have the form ‘area/city’, such as ‘America/Los_Angeles’. Zone offsets must be in the format ‘(+|-)HH’, ‘(+|-)HH:mm’ or ‘(+|-)HH:mm:ss’, e.g ‘-08’, ‘+01:00’ or ‘-13:33:33’., and must be in the range from -18:00 to +18:00. 'Z' and 'UTC' are accepted as synonyms for '+00:00'. SQLSTATE: 22009 ``` ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48260 from itholic/SPARK-49773. Lead-authored-by: Haejoon Lee <haejoon.lee@databricks.com> Co-authored-by: Haejoon Lee <haejoon@apache.org> Signed-off-by: Haejoon Lee <haejoon.lee@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix the uncaught Java exception from
make_timestamp()with bad timezoneWhy are the changes needed?
To improve the error message
Does this PR introduce any user-facing change?
No API changes, but the user-facing error message is changed:
Before
After
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No