[SPARK-49744][SS][PYTHON] Implement TTL support for ListState in TransformWithStateInPandas #48253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
approved these changes
Oct 4, 2024
...main/scala/org/apache/spark/sql/execution/python/TransformWithStateInPandasStateServer.scala
Outdated
Show resolved
Hide resolved
HeartSaVioR
reviewed
Oct 4, 2024
| ], | ||
| ) | ||
| elif batch_id == 2: | ||
| # ttl-count-0 expire and restart from count 0. | ||
| # ttl-count-1 get reset in batch 1 and keep the state | ||
| # ttl-count-1 get reset in batch 1 and keep the state. |
There was a problem hiding this comment.
nit: it may not be very clear what "reset" means here - now I get what you mean, "TTL reset", but I was puzzled and had to think a bit. Same for ttl-list-state-count-1.
There was a problem hiding this comment.
Updated the comment with more details, thanks!
|
Thanks! Merging to master. |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…sformWithStateInPandas ### What changes were proposed in this pull request? Implement TTL support for ListState in TransformWithStateInPandas. ### Why are the changes needed? Allow users to add TTL to specific list state. ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Added unit tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48253 from bogao007/ttl-list-state. Authored-by: bogao007 <bo.gao@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement TTL support for ListState in TransformWithStateInPandas.
Why are the changes needed?
Allow users to add TTL to specific list state.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Added unit tests.
Was this patch authored or co-authored using generative AI tooling?
No