Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4870] Add spark version to driver log #3717

Closed
wants to merge 4 commits into from
Closed

[SPARK-4870] Add spark version to driver log #3717

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e833330
add spark version to driver log
liyezhang556520 Dec 17, 2014
96dc115
remove curly brace
liyezhang556520 Dec 17, 2014
330f70c
move the log from SaprkConf to SparkContext
liyezhang556520 Dec 22, 2014
ccd30d7
delete log in sparkConf
liyezhang556520 Dec 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/scala/org/apache/spark/SparkConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,8 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging {
/** Checks for illegal or deprecated config settings. Throws an exception for the former. Not
* idempotent - may mutate this conf object to convert deprecated settings to supported ones. */
private[spark] def validateSettings() {
logInfo(s"Spark Version: $SPARK_VERSION")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like the right place for this. I would put it in SparkContext itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewor14 , yes, it does seem like not the right place here, It's better to put it in SparkContext. But the code would be a little ugly if put the log there, see my next commit in this PR. Is there any better way?

if (settings.contains("spark.local.dir")) {
val msg = "In Spark 1.0 and later spark.local.dir will be overridden by the value set by " +
"the cluster manager (via SPARK_LOCAL_DIRS in mesos/standalone and LOCAL_DIRS in YARN)."
Expand Down