[SPARK-4870] Add spark version to driver log #3717
Conversation
|
Test build #24529 has started for PR 3717 at commit
|
|
Test build #24529 has finished for PR 3717 at commit
|
|
Test FAILed. |
|
jenkins, retest this please. |
|
Test build #24530 has started for PR 3717 at commit
|
|
Test build #24530 has finished for PR 3717 at commit
|
|
Test FAILed. |
This bypasses unnecessary calls to the Github and JIRA API. Additionally, having a local cache allows us to remember names that we had to manually discover ourselves.
|
Jenkins, retest this please. |
|
The build was broken, but it's been fixed now. |
|
Test build #24536 has started for PR 3717 at commit
|
|
Test build #24536 has finished for PR 3717 at commit
|
|
Test PASSed. |
| @@ -240,6 +240,8 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging { | |||
| /** Checks for illegal or deprecated config settings. Throws an exception for the former. Not | |||
| * idempotent - may mutate this conf object to convert deprecated settings to supported ones. */ | |||
| private[spark] def validateSettings() { | |||
| logInfo(s"Spark Version: $SPARK_VERSION") | |||
|
|
|||
There was a problem hiding this comment.
This doesn't seem like the right place for this. I would put it in SparkContext itself
There was a problem hiding this comment.
Hi @andrewor14 , yes, it does seem like not the right place here, It's better to put it in SparkContext. But the code would be a little ugly if put the log there, see my next commit in this PR. Is there any better way?
|
Test build #24692 has started for PR 3717 at commit
|
|
Test build #24693 has started for PR 3717 at commit
|
|
Test build #24692 has finished for PR 3717 at commit
|
|
Test PASSed. |
|
Test build #24693 has finished for PR 3717 at commit
|
|
Test PASSed. |
|
This looks fine. I'm going to tweak the log format a little bit when I merge it into master. Thanks |
No description provided.