Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-20631][FOLLOW-UP] Fix incorrect tests. #18085

Closed
wants to merge 3 commits into from
Closed

[SPARK-20631][FOLLOW-UP] Fix incorrect tests. #18085

wants to merge 3 commits into from

Conversation

zero323
Copy link
Member

@zero323 zero323 commented May 24, 2017

What changes were proposed in this pull request?

  • Fix incorrect tests for _check_thresholds.
  • Move test to ParamTests.

How was this patch tested?

Unit tests.

@zero323 zero323 mentioned this pull request May 24, 2017
Closed
@SparkQA
Copy link

SparkQA commented May 24, 2017

Test build #77298 has finished for PR 18085 at commit b780da2.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 24, 2017

Test build #77299 has finished for PR 18085 at commit 04ad0f2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yanboliang
Copy link
Contributor

LGTM, merged into master and branch-2.2. Thanks.

asfgit pushed a commit that referenced this pull request May 24, 2017
@zero323 @yanboliang
[SPARK-20631][FOLLOW-UP] Fix incorrect tests.
1d10724 
## What changes were proposed in this pull request?

- Fix incorrect tests for `_check_thresholds`.
- Move test to `ParamTests`.

## How was this patch tested?

Unit tests.

Author: zero323 <zero323@users.noreply.github.com>

Closes #18085 from zero323/SPARK-20631-FOLLOW-UP.

(cherry picked from commit 1816eb3)
Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
@asfgit asfgit closed this in 1816eb3 May 24, 2017
@jkbradley
Copy link
Member

Thanks for fixing this! Just curious: did you figure out why the test was working before?

@zero323
Copy link
Member Author

zero323 commented May 24, 2017

The root problem was lack of test in the method name, so it hasn't been executed during the tests.

@zero323 zero323 deleted the SPARK-20631-FOLLOW-UP branch February 2, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zero323 @SparkQA @yanboliang @jkbradley