[SPARK-20631][PYTHON][ML] LogisticRegression._checkThresholdConsistency should use values not Params #17891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76548 has finished for PR 17891 at commit
|
|
Test build #76549 has finished for PR 17891 at commit
|
|
cc @jkbradley |
|
LGTM, merged into master and branch-2.2/2.1/2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 10, 2017
…cy should use values not Params ## What changes were proposed in this pull request? - Replace `getParam` calls with `getOrDefault` calls. - Fix exception message to avoid unintended `TypeError`. - Add unit tests ## How was this patch tested? New unit tests. Author: zero323 <zero323@users.noreply.github.com> Closes #17891 from zero323/SPARK-20631. (cherry picked from commit 804949c) Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
May 10, 2017
…cy should use values not Params ## What changes were proposed in this pull request? - Replace `getParam` calls with `getOrDefault` calls. - Fix exception message to avoid unintended `TypeError`. - Add unit tests ## How was this patch tested? New unit tests. Author: zero323 <zero323@users.noreply.github.com> Closes #17891 from zero323/SPARK-20631. (cherry picked from commit 804949c) Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
May 10, 2017
…cy should use values not Params ## What changes were proposed in this pull request? - Replace `getParam` calls with `getOrDefault` calls. - Fix exception message to avoid unintended `TypeError`. - Add unit tests ## How was this patch tested? New unit tests. Author: zero323 <zero323@users.noreply.github.com> Closes #17891 from zero323/SPARK-20631. (cherry picked from commit 804949c) Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
|
Thanks @yanboliang! |
jkbradley
reviewed
May 24, 2017
| def logistic_regression_check_thresholds(self): | ||
| self.assertIsInstance( | ||
| LogisticRegression(threshold=0.5, thresholds=[0.5, 0.5]), | ||
| LogisticRegressionModel |
There was a problem hiding this comment.
@zero323 @yanboliang Am I missing something? Why should the LogisticRegression constructor return an instance of type LogisticRegressionModel? Should you have to call fit?
There was a problem hiding this comment.
It shouldn't, but it's weird that Jenkins always passed the test. Anyway, let's fix it. Thanks for catching this.
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
…cy should use values not Params ## What changes were proposed in this pull request? - Replace `getParam` calls with `getOrDefault` calls. - Fix exception message to avoid unintended `TypeError`. - Add unit tests ## How was this patch tested? New unit tests. Author: zero323 <zero323@users.noreply.github.com> Closes apache#17891 from zero323/SPARK-20631.
|
@jkbradley It shouldn't. It is not a correct test #18085 |
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Aug 20, 2018
…cy should use values not Params - Replace `getParam` calls with `getOrDefault` calls. - Fix exception message to avoid unintended `TypeError`. - Add unit tests New unit tests. Author: zero323 <zero323@users.noreply.github.com> Closes apache#17891 from zero323/SPARK-20631. (cherry picked from commit 804949c) Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
getParamcalls withgetOrDefaultcalls.TypeError.How was this patch tested?
New unit tests.