Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-15980] [SQL] Support Stata-like tabulation of values in a single column, optionally with weights #13614

Closed
wants to merge 4 commits into from

Conversation

shafiquejamal
Copy link

What changes were proposed in this pull request?

See JIRA ticket: https://issues.apache.org/jira/browse/SPARK-15890

How was this patch tested?

Test is included.

I suspect that the changes in the /dev/pr-deps directory should not have been committed, but I would think that the .gitignore file would have prevented this.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jun 12, 2016

I think it will be nicer if the title of this PR follows https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

@shafiquejamal
Copy link
Author

Hello, I read the rules at the link before creating the Jira ticket and pull request, and I think I am in compliance. Can you please tell me which point at that link I have not complied with? Thanks.

@sadikovi
Copy link
Contributor

@shafiquejamal
The PR title should be of the form [SPARK-xxxx] [COMPONENT] Title, where SPARK-xxxx is the relevant JIRA number, COMPONENT is one of the PR categories shown at https://spark-prs.appspot.com/ and Title may be the JIRA's title or a more specific title describing the PR itself.

@shafiquejamal
Copy link
Author

shafiquejamal commented Jun 12, 2016

Ok, I'll edit this to make the title correct. Thanks.

@shafiquejamal shafiquejamal changed the title Support Stata-like tabulation of values in a single column, optionally with weights [SPARK-15980] [SQL] Support Stata-like tabulation of values in a single column, optionally with weights Jun 12, 2016
@shafiquejamal
Copy link
Author

Hello, just wanted to know what else I should do in order for this PR to be accepted. Thanks.

@srowen
Copy link
Member

srowen commented Jun 29, 2016

This PR looks like it has some problems. It adds some deps files that are unrelated. Generally you'd want to argue that this functionality is important enough to justify the burden of maintaining it as an API. I'm not (yet) sure it is.

@maropu maropu mentioned this pull request Apr 23, 2017
maropu added a commit to maropu/spark that referenced this pull request Apr 23, 2017
@asfgit asfgit closed this in e9f9715 Apr 24, 2017
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues).

// Open PRs whose JIRA tickets have been already closed
Closes apache#11785
Closes apache#13027
Closes apache#13614
Closes apache#13761
Closes apache#15197
Closes apache#14006
Closes apache#12576
Closes apache#15447
Closes apache#13259
Closes apache#15616
Closes apache#14473
Closes apache#16638
Closes apache#16146
Closes apache#17269
Closes apache#17313
Closes apache#17418
Closes apache#17485
Closes apache#17551
Closes apache#17463
Closes apache#17625

// Open PRs whose JIRA tickets does not exist and they are not minor issues
Closes apache#10739
Closes apache#15193
Closes apache#15344
Closes apache#14804
Closes apache#16993
Closes apache#17040
Closes apache#15180
Closes apache#17238

N/A

Author: Takeshi Yamamuro <yamamuro@apache.org>

Closes apache#17734 from maropu/resolved_pr.

Change-Id: Id2e590aa7283fe5ac01424d30a40df06da6098b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants