[SPARK-4452][SPARK-11293][Core][BRANCH-1.6] Shuffle data structures can starve others on the same thread for memory #13027
Conversation
|
Test build #58238 has finished for PR 13027 at commit
|
|
This pr is great for us, solved some ExecutorLost problems for branch-1.6. |
|
ping @davies @JoshRosen |
|
@davies , could you review this pr and merge it? |
|
@lianhuiwang This is not a fix for bug or regression in 1.6, so we may not merge this into 1.6. We could re-visit this if we plan to have another release for 1.6. |
|
@davies Thanks. Many people said they need it for 1.6 in issue, So I submit this PR. |
|
@lianhuiwang This PR is useful, other people could easily patch it by themselves, thanks for it. |
|
Test build #59141 has finished for PR 13027 at commit
|
|
@davies Why haven't we pulled this into branch 1.6? can we upmerge and pull in so that if we do 1.6.3 its there? |
|
@tgravescs For minor releases, we (the community) usually do not put much effort on the QA, it's risky to pull in large change (like this one) it. At least, I don't have enough confidence to merge this one. Sorry for that. |
Closes apache#11785 Closes apache#13027 Closes apache#13614 Closes apache#13761 Closes apache#15197 Closes apache#14006 Closes apache#12576 Closes apache#15447 Closes apache#13259 Closes apache#15616 Closes apache#14473 Closes apache#16638 Closes apache#16146 Closes apache#17269 Closes apache#17313 Closes apache#17418 Closes apache#17485 Closes apache#17551 Closes apache#17463 Closes apache#17625 Closes apache#10739 Closes apache#15193 Closes apache#15344 Closes apache#14804 Closes apache#16993 Closes apache#17040 Closes apache#15180 Closes apache#17238
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closes apache#11785 Closes apache#13027 Closes apache#13614 Closes apache#13761 Closes apache#15197 Closes apache#14006 Closes apache#12576 Closes apache#15447 Closes apache#13259 Closes apache#15616 Closes apache#14473 Closes apache#16638 Closes apache#16146 Closes apache#17269 Closes apache#17313 Closes apache#17418 Closes apache#17485 Closes apache#17551 Closes apache#17463 Closes apache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closes apache#10739 Closes apache#15193 Closes apache#15344 Closes apache#14804 Closes apache#16993 Closes apache#17040 Closes apache#15180 Closes apache#17238 N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closes apache#17734 from maropu/resolved_pr. Change-Id: Id2e590aa7283fe5ac01424d30a40df06da6098b5
What changes were proposed in this pull request?
This PR is for the branch-1.6 version of the commits PR #10024.
In #9241 It implemented a mechanism to call spill() on those SQL operators that support spilling if there is not enough memory for execution.
But ExternalSorter and AppendOnlyMap in Spark core are not worked. So this PR make them benefit from #9241. Now when there is not enough memory for execution, it can get memory by spilling ExternalSorter and AppendOnlyMap in Spark core.
How was this patch tested?
unit tests