[SPARK-14637][SQL] object expressions cleanup #12399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #55825 has finished for PR 12399 at commit
|
|
Test build #56164 has finished for PR 12399 at commit
|
| } | ||
|
|
||
| val value = unboxer(s"${obj.value}.$functionName($argString)") |
There was a problem hiding this comment.
Don't we need to do unboxing anymore here?
There was a problem hiding this comment.
We do, but I simplified it, see the callFunc above.
|
Sorry this went stale. Do we still want to try and get this in? |
|
Test build #57408 has finished for PR 12399 at commit
|
|
retest this please. |
|
Test build #57410 has finished for PR 12399 at commit
|
|
retest this please |
|
Test build #57427 has finished for PR 12399 at commit
|
|
Thanks, merging to master and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
May 2, 2016
## What changes were proposed in this pull request? Simplify and clean up some object expressions: 1. simplify the logic to handle `propagateNull` 2. add `propagateNull` parameter to `Invoke` 3. simplify the unbox logic in `Invoke` 4. other minor cleanup TODO: simplify `MapObjects` ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes #12399 from cloud-fan/object. (cherry picked from commit 0513c3a) Signed-off-by: Michael Armbrust <michael@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplify and clean up some object expressions:
propagateNullpropagateNullparameter toInvokeInvokeTODO: simplify
MapObjectsHow was this patch tested?
existing tests.