Implement EventsByTagQuery in PersistenceTestKitReadJournal

[ptrdom]

Resolves #1527.

[ptrdom]

Seeing complication errors on 2.12, will fix.

[ptrdom]

Aha, so tests have to compile on 2.12 too, will fix.

[ptrdom]

@pjfanning Seems like the only issue is with timeouts in link validator, IIUC it is a temporary failure. Is the PR otherwise fine?

[pjfanning]

Don't worry about the Link Validator. The changes look ok to me. I would like to let other people review this before it gets merged. I think this is safe for the v1.1.3 release but I want to get other opinions.

[pjfanning]

@ptrdom would you consider filling in a CLA?

https://www.apache.org/licenses/contributor-agreements.html

[ptrdom]

Sure, cannot see a reason not to file.

[pjfanning]

Sure, cannot see a reason not to file.

Thanks @ptrdom

[ptrdom]

@pjfanning I got a message that my ICLA has been filed in the Apache Software Foundation records and that I need to contact a project to progress my application. And that I should let the project know about my preferred Apache ID, which is the same as my GitHub username - ptrdom. This is assuming your message counted as an invitation to be a committer.

[pjfanning]

@pjfanning I got a message that my ICLA has been filed in the Apache Software Foundation records and that I need to contact a project to progress my application. And that I should let the project know about my preferred Apache ID, which is the same as my GitHub username - ptrdom. This is assuming your message counted as an invitation to be a committer.

Thanks for filling in the iCLA. In theory, the ASF requires them for significant code changes. They are also required for new committers, etc. I haven't received any notification from the ASF Secretary. This usually happens when the iCLA email includes the ASF project name. I can look it up myself but I need the full email address that you used to send the iCLA. The tool that I have access to only supports lookups with the full email address.

[pjfanning]

@ptrdom I found your iCLA in the ASF foundation svn repo so that is enough to proceed.

[pjfanning]

lgtm