Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EventsByTagQuery in PersistenceTestKitReadJournal #1527

Closed
ptrdom opened this issue Oct 10, 2024 · 1 comment · Fixed by #1532
Closed

Implement EventsByTagQuery in PersistenceTestKitReadJournal #1527

ptrdom opened this issue Oct 10, 2024 · 1 comment · Fixed by #1532

Comments

@ptrdom
Copy link
Member

ptrdom commented Oct 10, 2024

When attempting to implement runtime persistence plugin configuration for pekko-projection I ran into an issue where PersistenceTestKitReadJournal does not implement EventsByTagQuery, so it cannot be used to implement tests. Real persistence layers, like Cassandra, JDBC and Leveldb of course do implement EventsByTagQuery, but it would be quite useful if testkit was able to provide this behavior too. From a quick look it looks to me like an implementation similar to EventsByPersistenceIdStage should not be too complicated to do.

This is related to #1513 - need to have both EventSourcedBehavior and EventSourcedProvider be able to take configs at runtime to enable building typical applications using this functionality.

I could work on this feature if it were to be accepted.

@pjfanning
Copy link
Contributor

Seems useful to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants