arch/risc-v/espressif: Remove usb serial workaround for esp32 modules #15920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
434755e to
679848a
Compare
|
@tmedicci @eren-terzioglu, can you review, please? |
lupyuen
approved these changes
Mar 2, 2025
Hi, |
jerpelea
approved these changes
Mar 4, 2025
jerpelea
requested changes
Mar 4, 2025
ce9883b to
0b65d80
Compare
This commit includes a change to the esp_txint function in the arch/risc-v/src/common/espressif/esp_usbserial.c file. The change primarily involves removing an optimization workaround and adding a call to flush the transmit FIFO.
After this change the usbserial config is able to work using all optimization levels.
Changes in esp_txint function:
Removed the __attribute__((optimize("O0"))) workaround.
Added a call to usb_serial_jtag_ll_txfifo_flush() at the beginning of the function.
Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
0b65d80 to
eb621b5
Compare
jerpelea
approved these changes
Mar 5, 2025
eren-terzioglu
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
esp_txintfunction in thearch/risc-v/src/common/espressif/esp_usbserial.cfile. The change primarily involves removing an optimization workaround and adding a call to flush the transmit FIFO.After this change the usbserial config is able to work using all optimization levels.
Changes in
esp_txintfunction:__attribute__((optimize("O0")))workaround.usb_serial_jtag_ll_txfifo_flush()at the beginning of the function.Remove workaround related riscv esp32 modules usbserial driver.Testing
Using esp32c6, apply usbconsole config, build and flash, you will be able to use console by usb.
This PR solve the issue: #15656