Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-10184: mention to opening a Jira issue #781

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

mocobeta
Copy link
Contributor

@mocobeta mocobeta commented Apr 4, 2022

Maybe good to add a request to open a Jira before opening a PR? I'm not sure if there is a policy about it, I noted it's "optional" but required when the contribution should be mentioned in CHANGES.

@mocobeta
Copy link
Contributor Author

mocobeta commented Apr 4, 2022

We could simply add the PR number in the CHANGES and I think it'd be developer-friednly; however, I don't think this works at this moment.

@mocobeta
Copy link
Contributor Author

mocobeta commented Apr 4, 2022

@dweiss Thank you for confirming.

@mocobeta mocobeta merged commit 459d361 into apache:main Apr 4, 2022
@mocobeta mocobeta deleted the lucene-10184-add-mention-jira-issue branch April 4, 2022 11:09
wjp719 added a commit to wjp719/lucene that referenced this pull request Apr 5, 2022
* main:
  LUCENE-10456: Implement Weight#count for MultiRangeQuery (apache#731)
  LUCENE-10484: Move CHANGES entry to 9.2.
  LUCENE-10484: Add support for concurrent facets random sampling (apache#765)
  LUCENE-10002: Replaces usages of FacetsCollector with FacetsCollectorManager (apache#764)
  LUCENE-10466: Move changelog entry to 9.2
  LUCENE-10466: Ensure IndexSortSortedNumericDocValuesRangeQuery handles sort types besides LONG
  LUCENE-10498: don't count num hits nor accumulate scores unless necessary (apache#782)
  LUCENE-10184: mention of opening a Jira issue (apache#781)
  Update link to contribution guide
  Remove redundant index (apache#776)
  Implement method to bulk add all collection elements to a PriorityQueue (apache#770)
  LUCENE-10491: Fix correctness bug in TaxonomyFacetSumValueSource score providing (apache#775)
  Replace usages of search(Query, Collector) in CheckHits (apache#763)
  LUCENE-10002: Add FixedBitSetCollector and corresponding collector manager to test framework (apache#766)
  LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict (apache#772)
  LUCENE-10184: add CONTRIBUTING.md; reorganize README. (apache#771)
  Add CHANGES entry for LUCENE-10325
  LUCENE-10325: Add getTopDims functionality to Facets (apache#747)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants