LUCENE-10002: Replaces usages of FacetsCollector with FacetsCollectorManager #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9654428 to
98a7a22
Compare
In the effort of decreasing usages of IndexSearcher#search(query, Collector) by using the corresponding method that accepts a collector manager, this commit replaces many usages of FacetsCollector with its corresponding existing collector manager.
98a7a22 to
74a9494
Compare
mikemccand
approved these changes
Mar 29, 2022
jpountz
approved these changes
Apr 5, 2022
jpountz
pushed a commit
that referenced
this pull request
Apr 5, 2022
…Manager (#764) In the effort of decreasing usages of IndexSearcher#search(query, Collector) by using the corresponding method that accepts a collector manager, this commit replaces many usages of FacetsCollector with its corresponding existing collector manager.
wjp719
added a commit
to wjp719/lucene
that referenced
this pull request
Apr 5, 2022
* main: LUCENE-10456: Implement Weight#count for MultiRangeQuery (apache#731) LUCENE-10484: Move CHANGES entry to 9.2. LUCENE-10484: Add support for concurrent facets random sampling (apache#765) LUCENE-10002: Replaces usages of FacetsCollector with FacetsCollectorManager (apache#764) LUCENE-10466: Move changelog entry to 9.2 LUCENE-10466: Ensure IndexSortSortedNumericDocValuesRangeQuery handles sort types besides LONG LUCENE-10498: don't count num hits nor accumulate scores unless necessary (apache#782) LUCENE-10184: mention of opening a Jira issue (apache#781) Update link to contribution guide Remove redundant index (apache#776) Implement method to bulk add all collection elements to a PriorityQueue (apache#770) LUCENE-10491: Fix correctness bug in TaxonomyFacetSumValueSource score providing (apache#775) Replace usages of search(Query, Collector) in CheckHits (apache#763) LUCENE-10002: Add FixedBitSetCollector and corresponding collector manager to test framework (apache#766) LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict (apache#772) LUCENE-10184: add CONTRIBUTING.md; reorganize README. (apache#771) Add CHANGES entry for LUCENE-10325 LUCENE-10325: Add getTopDims functionality to Facets (apache#747)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the effort of decreasing usages of IndexSearcher#search(query, Collector) by using the corresponding method that accepts a collector manager, this commit replaces many usages of FacetsCollector with its corresponding existing collector manager.
mainbranch../gradlew check.