-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Add k8s pipeline #340
Conversation
- name: Set up Go 1.16 | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version: 1.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use golang 1.19 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operator is implemented by version 1.16 now. If necessary, we can upgrade it.
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
============================================
- Coverage 61.37% 58.17% -3.21%
Complexity 1529 1529
============================================
Files 186 192 +6
Lines 9445 10606 +1161
Branches 924 924
============================================
+ Hits 5797 6170 +373
- Misses 3340 4068 +728
- Partials 308 368 +60
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -76,6 +77,10 @@ jobs: | |||
java-version: ${{ inputs.java-version }} | |||
distribution: ${{ inputs.jdk-distro }} | |||
cache: maven | |||
- name: Set up Go 1.16 | |||
uses: actions/setup-go@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can set if: ${{ matrix.profile == kubernetes}}
here, although it is not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you raise a good first issue about this optimization?
What changes were proposed in this pull request?
Add a github pipeline to run the tests of k8s
Why are the changes needed?
It can help us to verify the k8s patch
Does this PR introduce any user-facing change?
No
How was this patch tested?
No