Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Add k8s pipeline #340

Merged
merged 8 commits into from
Nov 18, 2022
Merged

[INFRA] Add k8s pipeline #340

merged 8 commits into from
Nov 18, 2022

Conversation

jerqi
Copy link
Contributor

@jerqi jerqi commented Nov 18, 2022

What changes were proposed in this pull request?

Add a github pipeline to run the tests of k8s

Why are the changes needed?

It can help us to verify the k8s patch

Does this PR introduce any user-facing change?

No

How was this patch tested?

No

@jerqi jerqi changed the title [Infra] Add k8s pipeline [INFRA] Add k8s pipeline Nov 18, 2022
- name: Set up Go 1.16
uses: actions/setup-go@v3
with:
go-version: 1.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use golang 1.19 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operator is implemented by version 1.16 now. If necessary, we can upgrade it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #340 (413c163) into master (1aa3661) will decrease coverage by 3.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #340      +/-   ##
============================================
- Coverage     61.37%   58.17%   -3.21%     
  Complexity     1529     1529              
============================================
  Files           186      192       +6     
  Lines          9445    10606    +1161     
  Branches        924      924              
============================================
+ Hits           5797     6170     +373     
- Misses         3340     4068     +728     
- Partials        308      368      +60     
Impacted Files Coverage Δ
...oy/kubernetes/operator/pkg/controller/util/util.go 9.37% <0.00%> (ø)
deploy/kubernetes/operator/pkg/webhook/manager.go 53.43% <0.00%> (ø)
...rnetes/operator/pkg/webhook/inspector/inspector.go 69.56% <0.00%> (ø)
...y/kubernetes/operator/pkg/webhook/inspector/rss.go 47.70% <0.00%> (ø)
...bernetes/operator/pkg/controller/controller/rss.go 32.48% <0.00%> (ø)
...y/kubernetes/operator/pkg/webhook/inspector/pod.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi requested a review from kaijchen November 18, 2022 11:08
@jerqi jerqi linked an issue Nov 18, 2022 that may be closed by this pull request
3 tasks
@jerqi
Copy link
Contributor Author

jerqi commented Nov 18, 2022

Could you help me review this patch? @zuston @kaijchen

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit d09b40b into apache:master Nov 18, 2022
@@ -76,6 +77,10 @@ jobs:
java-version: ${{ inputs.java-version }}
distribution: ${{ inputs.jdk-distro }}
cache: maven
- name: Set up Go 1.16
uses: actions/setup-go@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set if: ${{ matrix.profile == kubernetes}} here, although it is not required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you raise a good first issue about this optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Add k8s Operator pipeline
4 participants