[#2298] fix(server): Correct the metric of grpc_get_local_shuffle_data_process_latency #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_data_process_latency
zuston
commented
Dec 18, 2024
| GetLocalShuffleDataResponse.newBuilder() | ||
| .setStatus(status.toProto()) | ||
| .setRetMsg(msg) | ||
| .setData(UnsafeByteOperations.unsafeWrap(sdr.getData())) |
There was a problem hiding this comment.
the operation of sdr.getData() will cost too much time, so it should be scoped into the metrics recording
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2299 +/- ##
============================================
+ Coverage 52.27% 52.34% +0.07%
+ Complexity 3569 3362 -207
============================================
Files 543 513 -30
Lines 29797 27584 -2213
Branches 2779 2593 -186
============================================
- Hits 15575 14439 -1136
+ Misses 13227 12205 -1022
+ Partials 995 940 -55 ☔ View full report in Codecov by Sentry. |
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Dec 23, 2024
…ocal_shuffle_data_process_latency apache#2299
jerqi
pushed a commit
that referenced
this pull request
Jan 1, 2025
…a_process_latency (#2299) ### What changes were proposed in this pull request? Correct the metric of grpc_get_local_shuffle_data_process_latency ### Why are the changes needed? fix #2298 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Needn't Co-authored-by: Junfan Zhang <zhangjunfan@qiyi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Correct the metric of grpc_get_local_shuffle_data_process_latency
Why are the changes needed?
fix #2298
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Needn't