Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Incorrect grpc metric of grpc_get_local_shuffle_data_process_latency #2298

Closed
3 tasks done
zuston opened this issue Dec 18, 2024 · 0 comments · Fixed by #2299 or #2302
Closed
3 tasks done

[Bug] Incorrect grpc metric of grpc_get_local_shuffle_data_process_latency #2298

zuston opened this issue Dec 18, 2024 · 0 comments · Fixed by #2299 or #2302

Comments

@zuston
Copy link
Member

zuston commented Dec 18, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

As title described

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zuston pushed a commit to zuston/incubator-uniffle that referenced this issue Dec 18, 2024
[apache#2298] fix(server): Correct the metric of grpc_get_local_shuff…
f914e6c 
…le_data_process_latency
@zuston zuston mentioned this issue Dec 18, 2024
Merged
@zuston zuston closed this as completed in 8c55030 Dec 18, 2024
zuston pushed a commit to zuston/incubator-uniffle that referenced this issue Dec 20, 2024
[apache#2298] fix(server): followup to correct the metric of grpc_get…
028c715 
…_local_shuffle_index_process_latency
@zuston zuston mentioned this issue Dec 20, 2024
Merged
zuston pushed a commit to zuston/incubator-uniffle that referenced this issue Dec 23, 2024
[apache#2298] fix(server): followup to correct the metric of grpc_get…
c0a8721 
…_local_shuffle_index_process_latency
zuston pushed a commit to zuston/incubator-uniffle that referenced this issue Dec 23, 2024
BACKPORT: [apache#2298] fix(server): Correct the metric of grpc_get_l…
ed224af 
…ocal_shuffle_data_process_latency apache#2299
jerqi pushed a commit that referenced this issue Dec 24, 2024
@zuston
[#2298] fix(server): followup to correct the metric of grpc_get_local…
1c56e74 
…_shuffle_index_process_latency (#2302)

### What changes were proposed in this pull request?

followup to correct the metric of grpc_get_local_shuffle_index

### Why are the changes needed?

Fix: #2298 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Co-authored-by: Junfan Zhang <zhangjunfan@qiyi.com>
jerqi pushed a commit that referenced this issue Jan 1, 2025
@zuston @jerqi
[#2298] fix(server): Correct the metric of grpc_get_local_shuffle_dat…
7d07a9d 
…a_process_latency (#2299)

### What changes were proposed in this pull request?

Correct the metric of grpc_get_local_shuffle_data_process_latency

### Why are the changes needed?

fix #2298

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Needn't


Co-authored-by: Junfan Zhang <zhangjunfan@qiyi.com>
jerqi pushed a commit that referenced this issue Jan 1, 2025
@zuston @jerqi
[#2298] fix(server): followup to correct the metric of grpc_get_local…
b10a4bc 
…_shuffle_index_process_latency (#2302)

### What changes were proposed in this pull request?

followup to correct the metric of grpc_get_local_shuffle_index

### Why are the changes needed?

Fix: #2298 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Co-authored-by: Junfan Zhang <zhangjunfan@qiyi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@zuston