[#1501] fix(server): storage selection cache accidentally deleted when clearing stage level data. #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng stage level data. (apache#1501)
|
I have fixed the failure of CI. please review it. @zuston |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1505 +/- ##
=============================================
+ Coverage 0 55.27% +55.27%
- Complexity 0 2807 +2807
=============================================
Files 0 407 +407
Lines 0 21988 +21988
Branches 0 2077 +2077
=============================================
+ Hits 0 12153 +12153
- Misses 0 9077 +9077
- Partials 0 758 +758 ☔ View full report in Codecov by Sentry. |
zuston
reviewed
Feb 4, 2024
There was a problem hiding this comment.
LGTM. Thanks for your contribution @dingshun3016
And welcome the Uniffle community!
zuston
approved these changes
Feb 4, 2024
Thanks, I'm happy to join the community |
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
May 27, 2024
…ed when clearing stage level data. (apache#1505) avoid storage selection cache accidentally deleted Fix: (apache#1501) No. Unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
avoid storage selection cache accidentally deleted
Why are the changes needed?
Fix: (#1501)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests