Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1501] fix(server): storage selection cache accidentally deleted when clearing stage level data. #1502

Closed
wants to merge 0 commits into from

Conversation

dingshun3016
Copy link
Contributor

@dingshun3016 dingshun3016 commented Feb 4, 2024

What changes were proposed in this pull request?

avoid storage selection cache accidentally deleted

Why are the changes needed?

Fix: (#1501)

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

No.

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

@dingshun3016 dingshun3016 changed the title fix(server): storage selection cache accidentally deleted when cleari… (#1501)fix(server): storage selection cache accidentally deleted when cleari… Feb 4, 2024
@dingshun3016 dingshun3016 changed the title (#1501)fix(server): storage selection cache accidentally deleted when cleari… (#1501)fix(server): storage selection cache accidentally deleted when clearing stage level data. (#1501) Feb 4, 2024
@dingshun3016 dingshun3016 changed the title (#1501)fix(server): storage selection cache accidentally deleted when clearing stage level data. (#1501) (#1501)fix(server): storage selection cache accidentally deleted when clearing stage level data. Feb 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3b4618) 0.00% compared to head (81aae41) 55.27%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #1502       +/-   ##
=============================================
+ Coverage          0   55.27%   +55.27%     
- Complexity        0     2807     +2807     
=============================================
  Files             0      407      +407     
  Lines             0    21988    +21988     
  Branches          0     2077     +2077     
=============================================
+ Hits              0    12153    +12153     
- Misses            0     9077     +9077     
- Partials          0      758      +758     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zuston zuston changed the title (#1501)fix(server): storage selection cache accidentally deleted when clearing stage level data. [#1501] fix(server): storage selection cache accidentally deleted when clearing stage level data. Feb 4, 2024
@zuston
Copy link
Member

zuston commented Feb 4, 2024

Looks good, Please fix the failure of CI

@dingshun3016
Copy link
Contributor Author

Fixed in #1505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants