Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask] [operator] expose more fields for RSS #545

Closed
2 of 3 tasks
advancedxy opened this issue Feb 3, 2023 · 3 comments
Closed
2 of 3 tasks

[Subtask] [operator] expose more fields for RSS #545

advancedxy opened this issue Feb 3, 2023 · 3 comments
Assignees

Comments

@advancedxy
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

expose more fields in operator's CRD, such as RuntimeClassName, Tolerations, Annotation and Affinity, etc. Therefore the shuffle server cloud be deployed more flexible

Quoted from parent issue.

Parent issue

#462

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@advancedxy
Copy link
Contributor Author

@wangao1236 ao, would I assign this issue to you?

@wangao1236
Copy link
Collaborator

Ok, I'll do it.

advancedxy pushed a commit that referenced this issue Feb 6, 2023
… rss (#548)

### What changes were proposed in this pull request?
Support setting custom runtime class name and env for rss objects.

### Why are the changes needed?
More flexibility.
Fix issue #545.

### Does this PR introduce _any_ user-facing change?
For RSS cluster admin, they can set custom runtime class name and env of pods.

### How was this patch tested?
Manually verified and an added UT.
@advancedxy
Copy link
Contributor Author

Closed via #548

advancedxy added a commit that referenced this issue Feb 9, 2023
### What changes were proposed in this pull request?
Add runtime class name get/list permission for webhook

### Why are the changes needed?
webhook needs this permission to validate runtime class name

### Does this PR introduce _any_ user-facing change?
Yes. After this, users can specify runtimeClassName

### How was this patch tested?
Verified manually.
advancedxy pushed a commit that referenced this issue Feb 22, 2023
…tolerations (#641)

### What changes were proposed in this pull request?
Support specifying coordinator/shuffler server's affinity and tolerations fields for RSS spec.  

### Why are the changes needed?
1. Production environment deployment needs to use.
2. In order to provider flexible scheduling semantics

This is a followup of #545 

### Does this PR introduce _any_ user-facing change?
For RSS cluster admin, they can set custom affinity for shuffle servers and coordinators.

### How was this patch tested?
Added UTs and manually verified.

![image](https://user-images.githubusercontent.com/45311215/220524164-4d21758a-9f5e-4285-b455-2546058fe359.png)
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 5, 2023
…ity & tolerations (apache#641)

### What changes were proposed in this pull request?
Support specifying coordinator/shuffler server's affinity and tolerations fields for RSS spec.  

### Why are the changes needed?
1. Production environment deployment needs to use.
2. In order to provider flexible scheduling semantics

This is a followup of apache#545 

### Does this PR introduce _any_ user-facing change?
For RSS cluster admin, they can set custom affinity for shuffle servers and coordinators.

### How was this patch tested?
Added UTs and manually verified.

![image](https://user-images.githubusercontent.com/45311215/220524164-4d21758a-9f5e-4285-b455-2546058fe359.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants